-
-
Notifications
You must be signed in to change notification settings - Fork 518
Add support for extracting comment replies continuation #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Does it work also with comments continuations? Would this approach allow having both nested replies (for Peertube, I think) and replies continuations (when not all replies are loaded at once)? |
Yes! Nothing should break it, although I will check it manually. I would have to check this once again as I have not check if there's a different JSON structure for these continuations. Edit: Fixed
Yes, each comment would have an option replies To get reply Comments, you just call
This would be a regular continuation / getNextPage(), nothing should change. |
|
@FireMasterK ok, then this approach is good. Thank you :-) |
|
Just one small issue - this implementation doesn't support multi-level threads in one page request, but I think that can be done later. (I'm not sure if any services do this either) |
|
Is this PR ready to be reviewed and merged soon? |
extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItemExtractor.java
Outdated
Show resolved
Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java
Outdated
Show resolved
Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java
Outdated
Show resolved
Hide resolved
...g/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java
Show resolved
Hide resolved
...g/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsInfoItemExtractor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Stypox <[email protected]>
78ca1d2 to
6aabdc6
Compare
Stypox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you :-D
|
This will be merged after release 0.20.10 is released |
|
Do we need to squash the commits? |
|
I don't think that's needed |
This takes an alternative approach to #576
@Stypox could you verify that this approach is okay?